Skip to content

Update to nuget package#4

Merged
aholstrup1 merged 1 commit into
mainfrom
aholstrup/nugetgeneration
May 13, 2023
Merged

Update to nuget package#4
aholstrup1 merged 1 commit into
mainfrom
aholstrup/nugetgeneration

Conversation

@aholstrup1
Copy link
Copy Markdown
Contributor

No description provided.

@aholstrup1 aholstrup1 merged commit 871fd81 into main May 13, 2023
@aholstrup1 aholstrup1 deleted the aholstrup/nugetgeneration branch May 13, 2023 10:28
SPinkow referenced this pull request in GOB-Software-Systeme-DevOps/BCAppsGOB Feb 13, 2026
* Change subscriber from BaseApp to changes generic names (#2)

* Warehouse receipt for subcontracting purchase order lines (#1)

• Creation of warehouse receipts for each subcontracting purchase line (regardless of whether it is the last operation or not)
• Posting the "Warehouse Receipt" posts the purchase order line, which in turn posts the operation of the "Production Order".
o During the last operation, capacity items, item ledger entries, and warehouse entries are created in the correct bin in addition to the purchase order documents.
A "Warehouse Put-Away" is also created.
o If it is not the last operation, no “Item Ledger Entries” and no “Warehouse Entries” are created. Furthermore, no "Warehouse Put-Away" is created.
o The "Warehouse Put-Away" for last operation lines can also be posted.
• Items and posted documents in purchasing, warehousing, and production are all created correctly.
• Partial quantities can be posted at any level. Both in the warehouse receipt and in the warehouse putaway.
• Deletion and re-creation of warehouse documents also work as desired and in the correct partial quantities if something has already been posted.
• Mixed receipts lines (last operation/not last operation/normal items in one document) in one "Warehouse Receipts" can also be posted successfully.
• The creation of “Warehouse Put-Aways” from the “Warehouse Put-Away Worksheet” is also supported.

* [Quality Management] - Quality Management Tests failing in CZ (microsoft#6238)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Update missing Direct Cost Applied Account

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#616057](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/616057/?view=edit)

* Exposing Methods For EDocuments (microsoft#6221)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
EDocExport.Codeunit.al - Changed IsDocumentTypeSupported from local to
procedure (making it public)

EDocumentProcessing.Codeunit.al - Removed Access = Internal; property
(making the codeunit public)

EDocumentWorkFlowProcessing.Codeunit.al - Changed DoesFlowHasEDocService
from internal to procedure (making it public)

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes microsoft#6149

[AB#619113](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619113)

---------

Co-authored-by: tomasevicst <160541867+tomasevicst@users.noreply.github.com>
Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>

* Warehouse receipt for subcontracting order (#8)

* Warehouse receipt for subcontracting purchase order lines (#1)

• Creation of warehouse receipts for each subcontracting purchase line (regardless of whether it is the last operation or not)
• Posting the "Warehouse Receipt" posts the purchase order line, which in turn posts the operation of the "Production Order".
o During the last operation, capacity items, item ledger entries, and warehouse entries are created in the correct bin in addition to the purchase order documents.
A "Warehouse Put-Away" is also created.
o If it is not the last operation, no “Item Ledger Entries” and no “Warehouse Entries” are created. Furthermore, no "Warehouse Put-Away" is created.
o The "Warehouse Put-Away" for last operation lines can also be posted.
• Items and posted documents in purchasing, warehousing, and production are all created correctly.
• Partial quantities can be posted at any level. Both in the warehouse receipt and in the warehouse putaway.
• Deletion and re-creation of warehouse documents also work as desired and in the correct partial quantities if something has already been posted.
• Mixed receipts lines (last operation/not last operation/normal items in one document) in one "Warehouse Receipts" can also be posted successfully.
• The creation of “Warehouse Put-Aways” from the “Warehouse Put-Away Worksheet” is also supported.

* [Subcontracting] Update event subscribers in Whse.-Post Receipt codeunit for improved processing logic (#3)

* Add better error message at handling item tracking ehich is related to a subcontracting purchase order line (#4)

* Add Second SourceQuantityArray for Purchase Line for Subcontracting Item Tracking

* Better Item Tracking Handling and better Errormessage

* Change error message

* Check connected Purchase Lines at changing routings (#6)

* Check connected Purchase Lines at changing routings

* correct double line

* Changes after code review

* test: add integration tests for subcontracting warehouse operations (#5)

* test: add integration tests for subcontracting warehouse operations

- Create tests for Put-away from Warehouse Receipt and Worksheet.
- Implement tests for Last Operation scenarios in warehouse processes.
- Ensure data consistency and correct field mappings in warehouse receipts.
- Validate base quantity calculations for different units of measure.

* refactor: replace PostPutAway calls with RegisterWhseActivity in tests

- Updated multiple test cases to use LibraryWarehouse.RegisterWhseActivity
  instead of SubcWarehouseLibrary.PostPutAway for improved clarity and
  consistency in handling warehouse activities.

* test: enhance subcontracting warehouse tests for item tracking and posting

- Add tests to verify item tracking is not allowed for non-last operation
  purchase lines and warehouse receipt lines.
- Implement checks for output quantities in capacity ledger entries.
- Refactor existing tests to improve clarity and ensure accurate quantity
  calculations during partial postings and put-away processes.
- Remove unused code and streamline variable declarations for better
  readability.

* fix tests

* remove over receipt tests

* combine redundant tests

* feat: add undo functionality for purchase receipt in last operation tests

- Implement tests for undoing purchase receipts, including validation
  scenarios for when put-away has been registered.
- Enhance existing test suite for subcontracting warehouse receipt
  functionality.

* code cleanup

* W/pinkow/overreceipt with item tracking in subcontracting (#7)

* Remove double Merged Lines

* Add Check for over delivery at calling Item Tracking

* Corrections

* Name correction

---------

Co-authored-by: Steven Groß <steven.gross@gob.de>

---------

Co-authored-by: tomasevicst <160541867+tomasevicst@users.noreply.github.com>
Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>
Co-authored-by: Steven Groß <steven.gross@gob.de>
ChethanT pushed a commit that referenced this pull request Mar 4, 2026
* refactor initialization calls in test codeunits

* - Added calls to LibraryERMCountryData.UpdateInventoryPostingSetup()
  in location creation procedures to ensure inventory posting setup
darjoo pushed a commit that referenced this pull request Apr 6, 2026
Groenbech96 pushed a commit that referenced this pull request Jun 1, 2026
- Separate stderr capture in Invoke-GhApi to prevent warnings/notices
  from corrupting JSON output (review #1)
- Add --paginate to all gh api calls and switch to NDJSON jq filters
  (one value per line) so multi-page responses parse correctly. Note:
  --slurp cannot be combined with --jq so we cannot use that pattern
  (review #2, #3)
- Add timeout-minutes: 10 to the SyncLabel job (review #4)
- Pass action inputs (label, whatIf) via environment variables instead
  of direct GitHub Actions expression interpolation into the pwsh run
  block, eliminating the script-injection vector (review #5)

Not addressed:
- review #6 claimed actions/checkout v6.0.2 does not exist; verified
  via GitHub API that this SHA is tagged v6.0.2, matching the convention
  used by every other workflow in this repo. Kept as-is for consistency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant